search

traitecoevo / plant

Trait-Driven Models of Ecology and Evolution :evergreen_tree:
https://traitecoevo.github.io/plant
53 stars 20 forks source link

Move disturbance from environment to patch #290

Closed aornugent closed 3 years ago

aornugent commented 3 years ago

This PR decouples environment and disturbance, to later allow patches to be initialised with a pre-determined size distribution.

It's almost finished, but several (important) tests fail because the mean disturbance interval is not correctly set when creating the patch. I think this currently occurs in the environment constructors of each strategy?

aornugent commented 3 years ago

All tests now passing (locally at least!)

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.4%) to 79.504% when pulling b380bd4ed72e4be914a7b2ac85337f95079d4f23 on patch-disturbance into f38fd5320ad8c6648e0a5a7dac8914414da47bdd on develop.

codecov-commenter commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@a62df9b). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #290   +/-   ##
==========================================
  Coverage           ?   80.02%           
==========================================
  Files              ?       87           
  Lines              ?     7426           
  Branches           ?        0           
==========================================
  Hits               ?     5943           
  Misses             ?     1483           
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a62df9b...f4a2dfe. Read the comment docs.