Rename seed rain - Githubissues

traitecoevo / plant

Trait-Driven Models of Ecology and Evolution :evergreen_tree:

https://traitecoevo.github.io/plant

53 stars 20 forks source link

Rename seed rain #294

Closed aornugent closed 3 years ago

aornugent commented 3 years ago

Seed rain as a term is overloaded and can mean both input and output seed rain.

This PR renames:

seed_rain -> either offspring_arriving or offspring_produced depending on the context
seed_rains -> all_offspring_produced
add_seedling -> add_offspring_update (name TBC)
seed -> offspring
seeds -> all_offspring

Will update docs and generated files after review.

aornugent commented 3 years ago

add_seedling - > add_established_offspring might be better. Comes up in StochasticPatch I think 🤔

coveralls commented 3 years ago

Coverage remained the same at 79.948% when pulling 640c994bb9a711734c4b6957d827889225753269 on rename_seedrain into 2861d8bc554869a9be9f0dd6847ce56be6000372 on develop.

aornugent commented 3 years ago

Rebasing off develop got messy, will submit new PR.