search

traitecoevo / plant

Trait-Driven Models of Ecology and Evolution :evergreen_tree:
https://traitecoevo.github.io/plant
53 stars 20 forks source link

Enable state variables in Environment #305

Closed aornugent closed 2 years ago

aornugent commented 2 years ago

I'd like to merge this work onto the develop branch, in order to make another PR that separates Environment and Control objects so that we can better configure soil state (these commits are also on #306, but aren't directly related).

@itowers1 - do you mind if your notebooks also get pushed on to the develop branch? We can continue using the water branch after the PR is merged, it'll just tidy up the commit history.

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@3a23369). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head 2d5c42c differs from pull request most recent head 346bc2a. Consider uploading reports for the commit 346bc2a to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #305   +/-   ##
==========================================
  Coverage           ?   79.80%           
==========================================
  Files              ?       94           
  Lines              ?     8429           
  Branches           ?        0           
==========================================
  Hits               ?     6727           
  Misses             ?     1702           
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3a23369...346bc2a. Read the comment docs.

aornugent commented 2 years ago

Thanks @dfalster - will file an issue to rename Water -> FF16w.