search

traitecoevo / plant

Trait-Driven Models of Ecology and Evolution :evergreen_tree:
https://traitecoevo.github.io/plant
53 stars 20 forks source link

Decouple assimilation #313

Closed aornugent closed 2 years ago

aornugent commented 2 years ago

I took this one step further and moved the integrator into assimilator which is initialised per strategy anyway. This sets up a future where Control objects can be decoupled from strategies.

Let's check the benchmarks and verify there are no slowdowns. We can roll back a single commit to keep the integrator as part of FF16_Strategy.

codecov-commenter commented 2 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@99c443f). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head 8050344 differs from pull request most recent head 69c5c18. Consider uploading reports for the commit 69c5c18 to get more accurate results Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #313   +/-   ##
==========================================
  Coverage           ?   79.87%           
==========================================
  Files              ?       94           
  Lines              ?     8423           
  Branches           ?        0           
==========================================
  Hits               ?     6728           
  Misses             ?     1695           
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 99c443f...69c5c18. Read the comment docs.

aornugent commented 2 years ago

The results are similar to the previous run so this looks ok to me.