Compiler warnings fix

[devmitch]

This PR fixes almost all compiler warnings in the develop branch including the Rcpp and Boost warnings from #311. The only remaining warning is

 ff16w_strategy.cpp: In member function ‘virtual double plant::FF16w_Strategy::net_mass_production_dt(const plant::FF16_Environment&, double, double, bool)’:
 ff16w_strategy.cpp:30:16: warning: unused variable ‘water_’ [-Wunused-variable]
    30 |   const double water_ = water_access(environment, height, area_leaf_);

which I think is fine as the file doesn't seem to be fully implemented yet. It would be good to get a sanity check that the compilation process still works on other machines.

[dfalster]

Hi @devmitch

Nice work! I love quite compilers. Thank you!

It would be good to get a sanity check that the compilation process still works on other machines.

Works on my mac!

I've also just approved you as developer on this, so when you send a PR it will trigger automated tests to run via Github Actions. (FYI- These tests are stored in .github/worklfows. The R-CMD-check tests compilation and runs tests on 3 different architectures, so if tests pass here you can pretty confident about functionality on other machines: https://github.com/traitecoevo/plant/blob/develop/.github/workflows/R-CMD-check.yaml#L28

I agree with your take on the one remaining warning -- this is only partially implemented.

[codecov-commenter]

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@1de4d47). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #318   +/-   ##
==========================================
  Coverage           ?   79.93%           
==========================================
  Files              ?       94           
  Lines              ?     8461           
  Branches           ?        0           
==========================================
  Hits               ?     6763           
  Misses             ?     1698           
  Partials           ?        0           

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1de4d47...a18e2aa. Read the comment docs.

[dfalster]

Hi @devmitch - I just invited you to join plant team, which should give you write access for this repo.

Please go ahead and merge this into develop branch, using squash & merge. Also include good commit message linking to relevant issues, like you did above.