`.data` deprecated in tidyselect 1.2.0

[aornugent]

I receive various messages like this when running tests. I plan to address this by removing .data and will likely make this change on the fitness branch if no-one objects.

Warning (test-strategy-ff16.R:216:3): Report generation
Use of .data in tidyselect expressions was deprecated in tidyselect 1.2.0.
ℹ Please use `"min_height"` instead of `.data$min_height`
Backtrace:
  1. testthat::expect_message(...)
       at test-strategy-ff16.R:216:2
 33. dplyr:::summarise.grouped_df(...)
 34. dplyr:::summarise_cols(.data, dplyr_quosures(...), caller_env = caller_env())
 36. dplyr:::expand_across(dots[[i]])
 37. dplyr:::across_setup(...)
 40. tidyselect::eval_select(cols, data = across_cols)
 41. tidyselect:::eval_select_impl(...)
 45. tidyselect:::vars_select_eval(...)
 46. tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 47. tidyselect:::eval_and(expr, data_mask, context_mask)
 48. tidyselect:::walk_operand(y, data_mask, context_mask)
 49. tidyselect:::walk_data_tree(expr, data_mask, context_mask)
 50. tidyselect:::eval_bang(expr, data_mask, context_mask)
 51. tidyselect:::walk_data_tree(expr[[2]], data_mask, context_mask)
 52. tidyselect:::eval_c(expr, data_mask, context_mask)
 53. tidyselect:::reduce_sels(node, data_mask, context_mask, init = init)
 54. tidyselect:::walk_data_tree(new, data_mask, context_mask)
 55. tidyselect:::expr_kind(expr, context_mask, error_call)
 56. tidyselect:::call_kind(expr, context_mask, error_call)
─

[dfalster]

Sure

[dfalster]

My understanding is that you won't remove all instances of .data, only those is some of the dplyr functions.

Make sure you try with rcmdcheck::rcmdcheck; it used to complain when .data was missing