Closed aornugent closed 1 year ago
hi @aornugent
Yes! I also got small variations with the two species case in fitness branch compared to the PR on master (#355). You can see here that I updated the vals for 1 sp and 2sp tests
I wasn't able to run patch_eq2
and patch_eq3
so didn't update those
After all the changes in interface, these numbers are reassuringly concisent with the original, so I'm happy to accept them
As identified in #355, some fitness related functions are broken. The
fitness
branch brings these functions in line with latest version of theplant
API.The tests recently added in #355 nearly pass. I obtain a slightly different equilibrium birth rate at https://github.com/traitecoevo/plant/blob/2aab5cf6563d17546333482ca733fb0edcc87bd6/tests/testthat/test-support-fitness.R#L191
I also encounter a small difference at https://github.com/traitecoevo/plant/blob/d87ad24b79245e67fdcc76cad9077a2210a344dd/tests/testthat/test-support-fitness.R#L198
Strangely, no error is encountered for the two species case that shortly follows.