Closed dfalster closed 5 months ago
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: No coverage uploaded for pull request base (
develop@dffb3de
). Click here to learn what that means.:exclamation: Current head faa6151 differs from pull request most recent head f47ae90. Consider uploading reports for the commit f47ae90 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks Andrew, Isaac: Good feedback. I addressed those concerns in commit above. Once it passes I'll merge.
This PR attempts to simplify the language and methods used to both
Each of the above uses some numerical methods, and the language used for these was not very clear. There were also some options that were not really needed.
Changes include
canopy
->light_availability
(canopy was too vague)canopy.h
->resource_spline.h
(generalised) -[x] also pass in full function to integrator, so can simplify and generaliseResource_spline
(though currently limited on scale 0-1, see #385 )canopy.compute_canopy
->light_availability.compute_environment
(consistent with names elsewhere)canopy_light_*
->light_availability_spline_*
canopy::set_fixed_canopy
->light_availability::set_fixed_value
get_canopy_at_height
&canopy_openness
->get_value_at_height