traitecoevo / plant

Trait-Driven Models of Ecology and Evolution :evergreen_tree:
https://traitecoevo.github.io/plant
53 stars 20 forks source link

Clarify methods used to create spline of light environment and calculate assimilation #384

Closed dfalster closed 5 months ago

dfalster commented 5 months ago

This PR attempts to simplify the language and methods used to both

Each of the above uses some numerical methods, and the language used for these was not very clear. There were also some options that were not really needed.

Changes include

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (develop@dffb3de). Click here to learn what that means.

:exclamation: Current head faa6151 differs from pull request most recent head f47ae90. Consider uploading reports for the commit f47ae90 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #384 +/- ## ========================================== Coverage ? 83.00% ========================================== Files ? 98 Lines ? 9004 Branches ? 0 ========================================== Hits ? 7474 Misses ? 1530 Partials ? 0 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dfalster commented 5 months ago

Thanks Andrew, Isaac: Good feedback. I addressed those concerns in commit above. Once it passes I'll merge.