traitecoevo / taxonlookup

A versioned and dynamically updating taxonomic lookup table for land plants
http://onlinelibrary.wiley.com/doi/10.1111/2041-210X.12517/abstract
Other
31 stars 6 forks source link

more updating for datastorr #18

Closed wcornwell closed 8 years ago

wcornwell commented 8 years ago
taxonlookup:::plant_lookup_info()
Error in datastorr::github_release_info("traitecoevo/taxonlookup", filename = "plant_lookup.csv",  : 
  argument "path" is missing, with no default

ping: @richfitz

maybe:

plant_lookup_version_current <- function(local=TRUE, path=NULL) {
  datastorr::github_release_version_current(plant_lookup_info(info), local)
}

should be

plant_lookup_version_current <- function(local=TRUE, path=NULL) {
  datastorr::github_release_version_current(plant_lookup_info(path), local)
}
richfitz commented 8 years ago

yeah, that looks about right.

This does mean there's no test though so I'll add one at the same time.

wcornwell commented 8 years ago

If you're going to work on tests, check:

https://codecov.io/github/traitecoevo/taxonlookup/R/plant_lookup.R?ref=d73b95f9fe89aef569b236fd00733b8eeaeca497

and

https://codecov.io/github/traitecoevo/taxonlookup/R/utils.R?ref=d73b95f9fe89aef569b236fd00733b8eeaeca497

wcornwell commented 8 years ago

fixed here: 122d7fe12081ae91757c9ff10c34c951cb552f5d