search

traitecoevo / taxonlookup

A versioned and dynamically updating taxonomic lookup table for land plants
http://onlinelibrary.wiley.com/doi/10.1111/2041-210X.12517/abstract
Other
31 stars 6 forks source link

Add a switch for APWeb families versus Plant list families #9

Closed wcornwell closed 9 years ago

richfitz commented 9 years ago

Is this in building the list or in loading it?

wcornwell commented 9 years ago

Peter was complaining about some of the plant list family definitions.

Maybe the easiest thing is to just add a column so that we don't mess up our dataset versioning system?

richfitz commented 9 years ago

Sure; family.apg perhaps. And then add a switch to the loading function to use it, but turn off by default. This is also where semantic versioning comes in useful; we can consider this a feature (update the middle number) or a breaking change and update the first.

wcornwell commented 9 years ago

Looks like the family lists actually line up--possibly the issue is more about which genera are in each family, and can't really fix that...I've left in some commented out code for if APweb and TPL family lists diverge in the future but not necessary at the moment.

richfitz commented 9 years ago

If Peter can furnish us with a list of edits I can apply that as a patch easily enough.

wcornwell commented 9 years ago

done