traitecoevo / traits.build

Source for the traits.build R package, used to build AusTraits
https://traitecoevo.github.io/traits.build/
Other
9 stars 0 forks source link

Running `metadata_add_source_doi` the first time reveals missing `rcrossref` package #178

Open hrlai opened 1 day ago

hrlai commented 1 day ago

Hi there, thanks for such a great package.

Just to report running the function metadata_add_source_doi the first time, I got

Error in loadNamespace(x) : there is no package called ‘rcrossref’

This went away after installing rcrossref. Might need to add it to the imports/dependencies?

ehwenk commented 22 hours ago

@dfalster I just checked the DESCRIPTION file and rcrossref is listed under Suggests. Does it need to be under Imports instead? It is used in setup.R, the function starting line 661, and also in tests.

ehwenk commented 22 hours ago

@hrlai Thanks for pointing this out to us! And for using the traits.build package.