search

traja-team / traja

Python tools for spatial trajectory and time-series data analysis
https://traja.readthedocs.io
MIT License
98 stars 25 forks source link

Empty manifold module #59

Open JustinShenk opened 3 years ago

JustinShenk commented 3 years ago

https://github.com/traja-team/traja/blob/master/traja/models/manifold.py is empty and has no test coverage. Please motivate inclusion or remove it.

Saran-nns commented 3 years ago

we have a new issue open for it. #58. Dimensionality reduction and visualization of the latent space has to be in manifold.py. As mentioned in the comments, this has to be integrated with the manifolds module at scikit-learn https://scikit-learn.org/stable/modules/manifold.html.

JustinShenk commented 3 years ago

Okay, thanks for your quick resposne. Maybe for the future we will push incomplete code to a feature branch so that master only has complete, releasable code.

On Sun 7. Feb 2021 at 18:46, Saranraj Nambusubramaniyan < notifications@github.com> wrote:

we have a new issue open for it. #58 https://github.com/traja-team/traja/issues/58. Dimensionality reduction and visualization of the latent space has to be under this manifold. As mentioned in the comments, this has to be integrated with the manifolds module at scikit-learn https://scikit-learn.org/stable/modules/manifold.html.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/traja-team/traja/issues/59#issuecomment-774717323, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOLMZE44CFBDR63HF3IYP3S53GXNANCNFSM4XHTTMQQ .

WolfByttner commented 3 years ago

Shall we remove the code from Master then? The code can be restored when someone is ready to work on it (the power of Git).