search

traja-team / traja

Python tools for spatial trajectory and time-series data analysis
https://traja.readthedocs.io
MIT License
98 stars 25 forks source link

Plotly imported but not used #64

Closed JustinShenk closed 3 years ago

JustinShenk commented 3 years ago

Plotly is required and imported but not used. Will this be developed further or can we remove it for now?

Line 5 of visualizer.py: import plotly.express as px.

The goal is to keep requirements to a minimum.

Saran-nns commented 3 years ago

plotly express is used to visualize the latent states at line 37. This class helps to visualize the relation between latent in state space, thereby one can evaluate latent disentanglement. We have this example in all notebooks that shared recently. But yes, plotly serves this purpose only.

JustinShenk commented 3 years ago

Thanks for your clarification. It doesn’t appear to be used in the code (search “px”). Is it still somehow affecting the plots or is it planning to be developed later?

On Sun 7. Feb 2021 at 23:02, Saranraj Nambusubramaniyan < notifications@github.com> wrote:

plotly express is used to visualize the latent states at line 37. This class helps to visualize the relation between latent in state space. and thereby one can evaluate latent disentanglement. We have this example in all notebooks that shared recently. But yes, plotly serves this purpose only.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/traja-team/traja/issues/64#issuecomment-774775920, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOLMZBLAUHF4QFMHMUZPW3S54EYJANCNFSM4XH3ZEOA .

Saran-nns commented 3 years ago

Plotly is used here

JustinShenk commented 3 years ago

Thanks! I must have missed it.

On Mon, Feb 8, 2021 at 10:21 PM Saranraj Nambusubramaniyan < notifications@github.com> wrote:

Plotly is used here https://github.com/traja-team/traja/blob/3717164b04ec4410f7ed7973ecaa0bc7007ec47a/traja/models/visualizer.py#L37

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/traja-team/traja/issues/64#issuecomment-775470144, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACOLMZDQRWIMFWOMHXDBH23S6BIUXANCNFSM4XH3ZEOA .