traja-team / traja

Python tools for spatial trajectory and time-series data analysis
https://traja.readthedocs.io
MIT License
98 stars 25 forks source link

Linter #71

Closed Saran-nns closed 3 years ago

Saran-nns commented 3 years ago

Issue #69 Removed the empty module irl and updated the init. Build success

codecov[bot] commented 3 years ago

Codecov Report

Merging #71 (b5743bc) into master (3717164) will increase coverage by 0.74%. The diff coverage is 60.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   70.22%   70.97%   +0.74%     
==========================================
  Files          27       26       -1     
  Lines        2657     2618      -39     
==========================================
- Hits         1866     1858       -8     
+ Misses        791      760      -31     
Impacted Files Coverage Δ
traja/dataset/pedestrian.py 30.00% <ø> (ø)
traja/frame.py 85.71% <ø> (ø)
traja/models/__init__.py 100.00% <ø> (ø)
traja/models/base_models/MLPClassifier.py 100.00% <ø> (ø)
traja/models/base_models/MLPRegressor.py 100.00% <ø> (ø)
traja/models/generative_models/vaegan.py 38.46% <ø> (ø)
traja/models/manifold.py 0.00% <ø> (ø)
traja/models/utils.py 72.50% <ø> (ø)
traja/models/visualizer.py 0.00% <0.00%> (ø)
traja/parsers.py 62.29% <ø> (ø)
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d6a8f8c...b5743bc. Read the comment docs.

Saran-nns commented 3 years ago

@WolfByttner @justinshenk Could someone please enlighten me about why the code patch failed here? 60.15% difference from the target ~70 seems too huge just for removing few lines of unused code.