search

trajano / wagon-git

Git wagon provider
Eclipse Public License 1.0
8 stars 10 forks source link

ssh-agent support _almost_ working for me #13

Closed jcflack closed 9 years ago

jcflack commented 9 years ago

I have a keypair for github, and as I would rather not put the passphrase in settings.xml I am trying out the recently added ssh-agent support. It works partially: my agent does prompt me for the passphrase, and the clone/fetch succeeds ... but then the push does not.

After some poking around, I think what's going on is that getGit was changed to call setTransportConfigCallback on the cloneRepository command object, but closeConnection may also need be changed to do that on the push command object too.

I'm going to get some sleep before I actually try that to see if it does the trick.

jcflack commented 9 years ago

Yes, that did it for me. Made pull request #14.