search

trakt-tools / universal-trakt-scrobbler

MIT License
528 stars 51 forks source link

Universal Amazon Prime endpoints #286

Closed MrMamen closed 1 year ago

MrMamen commented 1 year ago
MrMamen commented 1 year ago

@rafaelgomesxyz Can't seem to understand why the linting fails. Works locally for me.

MrMamen commented 1 year ago

@Throne3d Please check if this still works in your region.

Throne3d commented 1 year ago

Looks to be working, yep! Notably, I did have to go to the "Account & Settings" page and re-authenticate first (https://www.primevideo.com/region/na/settings/ref=atv_nb_set) before it would work, even though I was logged in on the main primevideo.com site. Maybe we could list that as an extra troubleshooting step for Prime, alongside the change here?

rafaelgomesxyz commented 1 year ago

So wait, I'm confused, how is this PR different than https://github.com/trakt-tools/universal-trakt-scrobbler/pull/274?

MrMamen commented 1 year ago

So wait, I'm confused, how is this PR different than https://github.com/trakt-tools/universal-trakt-scrobbler/pull/274?

274 is a WIP hardcoded for one region. This is a more general fix. I branches this off the other branch for history and credits.

MrMamen commented 1 year ago

Sorry. I see that I was working on the same branch as PR #274 so they are identical indeed.

rafaelgomesxyz commented 1 year ago

Oh I see, I'll add Co-authored-by: Throne3d when merging to give them credit.

But, is it actually working for you guys? I'm getting {"error":{"errorCode":"PRS.InvalidRequest","message":"Cannot complete request.","type":"PRSInvalidRequestException"}} in my responses from the requests to ITEM_URL, so history isn't loading and scrobbling is broken.

MrMamen commented 1 year ago

I added the co-authored-tag, but is it necessary? Isn't this automatically added as long as it is at least one commit by another developer?