trakt / script.trakt

Trakt.tv movie and TV show scrobbler for Kodi
GNU General Public License v2.0
324 stars 149 forks source link

Movie Playback progress issue #336

Open jpatriarca opened 7 years ago

jpatriarca commented 7 years ago

I'm using this actual environment:

For Kodi, I'm using a local MySQL database for my Video and Music library, for AppleTV + Infuse, their own database.

For Movie Playback progress, if i pause a movie in AppleTV/Infuse, everything is OK and it syncs with Trakt.tv. Also, on Kodi (whichever i use) everything is working as expected.

I'm detecting that, when i change movie playback progress status (select movie on library and press 'W' until it is marked and watched), when i re-sync to Trakt, it restores the status that are stored in Trakt and not updates the status from my local library, which I think it's incorrect since that the status should be correct from the local library or player (Kodi or Infuse) and not from Trakt.

Also, I've managed to manually delete the specific movie progress rows in MySQL, and when synchronized to Trakt, the respective lines are restored on MySQL database each time I sync my library with Trakt.

To test this behavior, I've made the following test:

The same behavior happens when it's related to tv series.

Trakt.tv progress status should not be the 'master' of the equation but just source of sync between several devices, that in my situation is related to sync between Kodi/MySQL to AppleTV/Infuse. If not, i should only disable Play progress sync on Kodi Trakt add-on.

Please review that, at least, we can define which info are the primary one (Trakt or local library).

Thank you

razzeee commented 7 years ago

Well it's kinda the expected behavior. Would be nice to get it to work better, but would be pretty hard / not doable in a sane way right now. We would need some way to know which data is the newest right now and even then we might be wrong. Because users might want to rewatch something, even if it's already set to watched and not loose their playback progress.

jpatriarca commented 7 years ago

This is not a Watched/Unwatched tag change issue (which works perfectly) but Movie/series progress tag archive in Trakt and the way that it syncs with local libraries.

I undestand your point mostly for those like me that have several players and need to sync this kind of info with them and some wrong behaviour that could happen, but being Trakt.tv the master of information when are the players that change the progress are akward. This should be only a repositovry and the players should be considered the master of information and any change be reflected to all the players when Trakt syncs. Maybe should be available on a specific menu where we manually delete the Movie/Series progress info from Trakt database, totally independent from the watched/unwatched tag. I understand that the sync are working perfectly, the situation is that any change on the player does not reflect in Trakt DB.

In Trakt web interface there is an option to delete this info?

razzeee commented 7 years ago

Nope, afaik know there is not.

What we could do, is just set the progress on an item to zero whenever you hit watched in kodi. But I'm not really sure if we're aware if it's unwatched local, as we're basically just doing a toggle. Will have to look at the code when I get some time.