search

trakt / script.trakt

Trakt.tv movie and TV show scrobbler for Kodi
GNU General Public License v2.0
322 stars 149 forks source link

Trakt rating dialog not coming after watching a movie #507

Closed onlytanmoy closed 4 years ago

onlytanmoy commented 4 years ago

Hiya @Razzeee the rating pop-up not coming after done watching a movie. Its only showing up for episodes alone which is odd as I thought the pop-up is handled similarly for movies and tv episodes or not? I am using Kodi 18.8 on Nvidia Shield Pro 2019. Unfortunately there is no other add-on AFAIK that can show this Trakt rating pop-up at the end of movie/episode, therefore coming to you to get this fixed. Please look into the matter.

razzeee commented 4 years ago

I can't replicate the problem, all working fine for me. Does it work for you if you pause the movie or do you only get it without pausing and skipping?

On Sat, Aug 15, 2020, 10:56 onlytanmoy notifications@github.com wrote:

Hiya @Razzeee https://github.com/Razzeee the rating pop-up not coming after done watching a movie. Its only showing up for episodes alone which is odd as I thought the pop-up is handled similarly for movies and tv episodes or not? I am using Kodi 18.8 on Nvidia Shield Pro 2019. Unfortunately there is no other add-on AFAIK that can show this Trakt rating pop-up at the end of movie/episode, therefore coming to you to get this fixed. Please look into the matter.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/trakt/script.trakt/issues/507, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNLEZHLUIOCVCU6YCBBBTLSAZESRANCNFSM4QAFNSHQ .

onlytanmoy commented 4 years ago

I don't get it at all, so the movie finishes playing but rating pop-up dialog never shows up. It does get marked as watched in my Trakt history though. Strange thing is for TV show episodes, the rating pop-up shows up instantly once done watching it. so failing to understand what's wrong for movies? How come it works only for TV episodes?

razzeee commented 4 years ago

Might be a problem with your scraper. I guess a log might help

On Sun, Aug 16, 2020, 16:03 onlytanmoy notifications@github.com wrote:

I don't get it at all, so the movie finishes playing but rating pop-up dialog never shows up. It does get marked as watched in my Trakt history though. Strange thing is for TV show episodes, the rating pop-up shows up instantly once done watching it. so failing to understand what's wrong for movies? How come it works only for TV episodes?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/trakt/script.trakt/issues/507#issuecomment-674530464, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNLEZFE4BT62AFOBI45IMLSA7RMBANCNFSM4QAFNSHQ .

onlytanmoy commented 4 years ago

ok sure, I am currently out of home, will share a log with you...in fact two logs- one successful one for TV episode and another unsuccessful one for movies. Will be great to have this back working again for me as really no other kodi add-on I know of that can handle trakt rating.

onlytanmoy commented 4 years ago

@Razzeee here you go mate, replicated the issue with movie not showing Trakt rating pop-up. Let me know if not able to view the log file. I will now grab another log with the case for TV episode where rating pop-up is shown as expected. kodi.log

razzeee commented 4 years ago

That's weird, there are only three log lines from trakt. Can you check if you followed https://github.com/trakt/script.trakt#creating-logfiles ?

onlytanmoy commented 4 years ago

Oh ok, I only enabled debug mode in Kodi. Have enabled debug in script.trakt as well now. Will share the log file shortly.

onlytanmoy commented 4 years ago

@Razzeee please see log file attached for movie case, unsuccessful one that is. I will get the log for TV episode now, successful case. kodi.log

onlytanmoy commented 4 years ago

And here is the log file for a TV episode scenario which displayed the rating pop-up immediately after show end. kodi.log

razzeee commented 4 years ago

however your watching this, we only get the year, not the name. So I'm guessing your using an online source, which either doesn't set it or sets it wrong.

It seems to set the title as showtitle (this is not a show but a movie), so the problem might be there.

Best would be if that addon could provide the actual ids, or at least the correct titles. The docs on how to do it correctly are here https://github.com/trakt/script.trakt/wiki/Providing-id%27s-to-facilitate-scrobbling

onlytanmoy commented 4 years ago

Ok, so you suggesting me to log a issue on this with the add-on as the add-on is not sending the right info. I used Fen in this example so will report an issue there with cross reference to this post. Thanks for checking for me.