Show watchlist content - Githubissues

trakt / script.trakt

Trakt.tv movie and TV show scrobbler for Kodi

GNU General Public License v2.0

318 stars 149 forks source link

Show watchlist content #516

Open fatshotty opened 3 years ago

fatshotty commented 3 years ago

Hello, first of all thanks for the great job :) I wander: is there a way to show "watchlist content" on kodi? I mean a sort of "playlist" showing all item in watchlist and then make them playable on kodi (if item is in my kodi library)

thanks in advance

razzeee commented 3 years ago

There were some explorations, but nothing that was ready for users. I think the idea was to create lists in kodi from the data.

fatshotty commented 3 years ago

Thanks for reply. I'm working on a pull request that lists Movie-Watchlist and TvShows-Watchlist. However I saw that the published addon version is 3.2.5, but "master" branch is 3.3.2. I'm working on 3.2.5, is it right? Maybe, cloud we discuss about solution that I'm developing on?

thanks in advance

razzeee commented 3 years ago

I'm not working on leia anymore, so I would prefer you to target matrix (master)

fatshotty commented 3 years ago

ok got it. Maybe I could fork 3.2.5 for kodi 18 and send pull-request on master for kodi 19 matrix ;)

fatshotty commented 2 years ago

Hi i'm developing a new addon based on trakt in additional to this addon. I would like to add some Trakt features such as:

show watchlist
show personal lists
show collected media
etc...

I'm try to use your addon "dependecy" but I cannot import your code. Is there a way to import your code in my addon? I think I could re-use your code in order to avoid a double authentication routine and so on... Could you help me, please?

razzeee commented 2 years ago

I'm not sure, in general this is not a library, but an application. If it were a library, this would be easier.

fatshotty commented 2 years ago

is it possibile to make it a library, too?

razzeee commented 2 years ago

is it possibile to make it a library, too?

Sure, but probably lots of work, as it was never meant to be one.

My python is rusty in that regard, it might already be possible, I just don't think you can reuse our auth, without it being problematic, as that depends on more then just the code. You would probably have to access our addon data too, which isn't a nice thing to do and would probably never get through a kodi repo review.

fatshotty commented 2 years ago

Yes, you're right. In my local repository I made my addon using script.module.trakt library and its methods. Moreover I'm using your addon's settings such as "username" and "authorization" keys. I made that just for test. As you know, those steps are not enough: I did need to get also the client_id and client_secret keys in order to execute http request

With my addon I would like to add some trakt's features such as:

browser personal lists
browser watchlist (film and tvshows)
contextual menu for "Add to list" on any item (film or tvshow)
add "suggest movie" in "rating popup"

How could I do these without create a new Trakt app and without make a new authentication in kodi addon?

thanks in advance

razzeee commented 2 years ago

Well send patches for this addon?

The only thing that should be different is, that context menu should be it's own addon, that speaks with this one. See: https://github.com/razzeee/context.trakt.rate

Well, being reminded of those, it might be possible to implement your buisness logic in this addon and have a different one calling it, like the context stuff does.