trakt / script.trakt

Trakt.tv movie and TV show scrobbler for Kodi
GNU General Public License v2.0
318 stars 149 forks source link

Rating popup locks ui after episode was switched using up next #519

Open Stimmenhotel opened 3 years ago

Stimmenhotel commented 3 years ago

Hello there, thanks for this awesome script!

Sadly I have a problem with trakt and upnext in combination. Since I now started using kodi on my android device (mi box s) again, I am experiencing this bug again. I think I found a workaround before or maybe it worked on libreelec/coreelec without problems. But I can't remember it, since it was quite a while ago (1-2 years?)

Now then ... The bug:

If I watch series I use upnext to automatically start the next episode. I am using trakt to rate every episode i watched.

Once the playback switched the episode the trakt rating popup shows up, I can move the rating, but I can't close the popup anymore. Neither with Ok not Cancel.

It doesn't happen every time... Sometimes the popup is delayed and I can use it like normal.

I am trying to get a log today, will add it to this issue once I found the time.

I am quite amazed no one else reported this, I can't be the only one ... I just made aclean install off kodi because the matrix update was causing some errors with obsolete add-ons I used for a skin i am not even used anymore.

razzeee commented 3 years ago

Can't get this to happen for me. Then again, how do you get a Ok or Cancel button? Are you using the default skin?

Stimmenhotel commented 3 years ago

Right now I am not at my setup and can't test it again. I am back early next year.

I am using default skins, yes.

The last time with nearly no modifications else than this two addons (Trakt and up next). The old device I used was a wetek hub starting coreelec with Kodi Leia. Now I am using Kodi on Android on my Xiaomi Mi Box S.

Dealz-416LS commented 3 years ago

@Stimmenhotel @Razzeee

Not sure if this is the same issue but for a while now the rating dialog has not worked properly/inconsistently.

when it pops up at the end of playback it will very often become unresponsive, not able to select a rating or press OK to confirm. Only option is to hit Back to dismiss the dialog box so unable to submit rating.

sometimes I’m able to choose a rating and hit OK if I’m quick if not it will become unresponsive and have to hit Back on remote to dismiss.

I usually stop playback at the end before the upnext dialog box but I’ll try with that and see what happens.

razzeee commented 3 years ago

Which platform? Which skin?

Dealz-416LS commented 3 years ago

@Razzeee

Kodi 18.9 - Nvidia Shield TV Arctic Horizon 0.5.55

razzeee commented 3 years ago

Can you try with estuary?

Dealz-416LS commented 3 years ago

@Razzeee I tested with Estuary 3 times and the rating dialog worked flawlessly - Tested with Arctic Horizon 2 times and it froze up and became unresponsive after about 3-4 seconds after moving between the rating. it's a Skin issue.

I also noticed that Estuary is so fast loading thing up, I've never used it before so i had no idea anyway thank you for the help!

Stimmenhotel commented 3 years ago

Thanks for trying @Dealz-416LS i am quite busy writing my exams, I am not even able to watch Netflix lately. A few weeks to go, I will keep the notifications unread and come back once I finished.

Estuary is the default skin, isn't it? I am using the default one on my device.

Dealz-416LS commented 3 years ago

@Stimmenhotel No Problem, Hopefully the issue I’m experiencing gets fixed with the Skin I use when it gets updated next.

Yes it’s the default skin and Good luck with your exams!

Dealz-416LS commented 3 years ago

@Razzeee Rating for movies doesn’t work for me, tested with current skin and with Estuary, double checked in setting and it’s checked for rating movies after playback, Only getting Show rating dialog.

razzeee commented 3 years ago

https://github.com/trakt/script.trakt/issues/519#creating-logfiles

Dealz-416LS commented 3 years ago

519 (comment)

@Razzeee Sorry I don’t see your reply?

razzeee commented 3 years ago

Sorry, meant to link this https://github.com/trakt/script.trakt#creating-logfiles

Dealz-416LS commented 3 years ago

kodi.log

razzeee commented 3 years ago

Hoped for an obvious error to be in there, can't spot that :/

Dealz-416LS commented 3 years ago

That’s unfortunate, I was hoping for the same.

I could be wrong I think at Line 299 the script-trakt-RatingDialog.xml is run, then loads the GUI on Line 300, but for the movie the xml is run on Line 574 but fails to load the GUI on the next Line.

razzeee commented 3 years ago

The log seems to have been already deleted from the server

Dealz-416LS commented 3 years ago

kodi.log

razzeee commented 3 years ago

I could be wrong I think at Line 299 the script-trakt-RatingDialog.xml is run, then loads the GUI on Line 300, but for the movie the xml is run on Line 574 but fails to load the GUI on the next Line.

Your wrong :) the first is the init of the window, line 574 is when that window is closed. See the timestamp, it's only seconds apart.

Also, please double check the instructions above, your log seems to not show the relevant logs.

Dealz-416LS commented 3 years ago

Oh lol, I didn't notice that :)

I doubled checked this time and I believe it's showing the relevant logs now as i see "DEBUG: [script.trakt]" which wasn't in the previous logs.

I skipped to the end of a show - got the rating dialog no problem then skipped to the end of a movie didn't get the rating dialog

kodi.log

razzeee commented 3 years ago

2021-01-18 19:24:05.221 T:20563 DEBUG: [script.trakt] resources.lib.scrobbler: Failed to scrobble movie: {'year': 2011, 'title': u''} | 98.153848588 | stop

Your movie does not have a title (or it doesn't tell it to trakt) but we got a year :D

Dealz-416LS commented 3 years ago

I tried with a different movie, same result

2021-01-18 20:08:16.384 T:20563 DEBUG: [script.trakt] resources.lib.scrobbler: Failed to scrobble movie: {'year': 2020, 'title': u''} | 96.7521595108 | stop

Do you know what is causing this?

razzeee commented 3 years ago

Your probably using a third party addon and not the local library. If that addon doesn't send this data, there's nothing we can do. https://github.com/trakt/script.trakt/wiki/Providing-id%27s-to-facilitate-scrobbling