search

trakt / script.trakt

Trakt.tv movie and TV show scrobbler for Kodi
GNU General Public License v2.0
318 stars 149 forks source link

[Bug] Trakt context menu & TMDB scraper for TV Shows library #530

Closed burekas7 closed 3 years ago

burekas7 commented 3 years ago

Hi,

When I set my TV Shows using the tmdb tv show scraper http://mirrors.kodi.tv/addons/leia/metadata.tvshows.themoviedb.org/metadata.tvshows.themoviedb.org-3.5.12.zip

The trakt context menu doesn't work well. For example if I open the context menu for an episode, and open the "trakt options" it takes the id which is now of tmdb id and make a search using tvdb instead, which is incorrect. Therefore when I choose to rate the episode for exmaple, it show the episode name of other tv show that the tmdb id is in TVDB.

What can I do in order to fix that?

Thanks.

razzeee commented 3 years ago

Tested on which kodi version?

Arthur1967 commented 3 years ago

What is the repository for the latest trakt version for kodi 18.9 Thank you

On Wed, Feb 17, 2021 at 2:22 PM Razzeee notifications@github.com wrote:

Tested on which kodi version?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/trakt/script.trakt/issues/530#issuecomment-780792511, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQWA4AFC6ZNXZLPOZUMBP3DS7QJQ5ANCNFSM4XYPY7FA .

razzeee commented 3 years ago

Official kodi repo

On Wed, Feb 17, 2021, 20:36 Arthur1967 notifications@github.com wrote:

What is the repository for the latest trakt version for kodi 18.9 Thank you

On Wed, Feb 17, 2021 at 2:22 PM Razzeee notifications@github.com wrote:

Tested on which kodi version?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <https://github.com/trakt/script.trakt/issues/530#issuecomment-780792511 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AQWA4AFC6ZNXZLPOZUMBP3DS7QJQ5ANCNFSM4XYPY7FA

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/trakt/script.trakt/issues/530#issuecomment-780800281, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABNLEZAQKIDDNWSZMT4QAITS7QLCNANCNFSM4XYPY7FA .

burekas7 commented 3 years ago

Tested on which kodi version? @Razzeee

I tested it on both version of 18.9 and 17.6, the same behavior. It makes the serach only by TVDB. So if I'm using TMDB scraper for TV Shows it use the TMDB ID for looking it in TVDB which is wrong.

How can I solve this?

angelitto2005 commented 3 years ago

@burekas7, why don't you use TVDB scraper for TV Shows and TMDB scraper for Movies. Maybe this way, your problem will be solved. I say this because i had problems with OpenInfo when i use TMDB scraper for TV Shows. But after i changed in settings the TVDB scraper for TV Shows, everything is ok again. Just a thought.

Arthur1967 commented 3 years ago

Because they want to start charging people each month for the use of their service mean well they get their directories from the users so they’re charging us for using our information so a lot of people have switched to the movie database

On Tue, Mar 2, 2021 at 7:41 AM angelitto2005 notifications@github.com wrote:

@burekas7 https://github.com/burekas7, why don't you use TVDB scraper for TV Shows and TMDB scrapper for Movies. Maybe this way, your problem will be solved. I say this because i had problems with OpenInfo when i use TMDB scraper for TV Shows. But after i changed in settings the TVDB scraper for TV Shows, everything is ok again. Just a thought.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/trakt/script.trakt/issues/530#issuecomment-788880111, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQWA4ACI7W7OBDE6ZAHL7LDTBTMF3ANCNFSM4XYPY7FA .

angelitto2005 commented 3 years ago

I checked again and i was talking about this: Captură de ecran 2021-03-02 150111

burekas7 commented 3 years ago

@burekas7, why don't you use TVDB scraper for TV Shows and TMDB scraper for Movies. Maybe this way, your problem will be solved. I say this because i had problems with OpenInfo when i use TMDB scraper for TV Shows. But after i changed in settings the TVDB scraper for TV Shows, everything is ok again. Just a thought.

All the years until today I was using only TVDB for TV Shows.

My reason of changing it to TMDB is because it is more updated and they have more translated content in my language. In addition, it is more convenient to update content in their site, rather then TVDB which is annoying platform for updating content.

razzeee commented 3 years ago

Tested on which kodi version? @Razzeee

I tested it on both version of 18.9 and 17.6, the same behavior. It makes the serach only by TVDB. So if I'm using TMDB scraper for TV Shows it use the TMDB ID for looking it in TVDB which is wrong.

How can I solve this?

Why do you think this is the case? I just tested a setup with the tmdb scraper, setting the bulk of the show 3% to watched and then syncing it as watched. It did work without problems.

burekas7 commented 3 years ago

@Razzeee

Hi,

Read again the main post. The sync is correct, I'm not talking about that. I mentioned that the problem is with the context menu: I tested that with: context.trakt.contextmenu-1.0.3

It takes the tmdb id and use it as tvdb id and search it in TVDB site, so it actually returns a wrong tv show. It should knows (or add a setting) if the scraper is by tmdb. so the searching should be with tmdb and not in tvdb. The same if the scraper is by TVDB, the searching should be with tvdb.

In order to test it: Select an episode, Open the context menu and select "Trakt Options" Select "Rate the episode" You can see the episode title that is wrong. It returns a tvdb tv show which suit to the tmdb id.

razzeee commented 3 years ago

Can you test https://github.com/trakt/script.trakt/pull/534

It seems to fix the problems on my test setup