search

trakt / script.trakt

Trakt.tv movie and TV show scrobbler for Kodi
GNU General Public License v2.0
318 stars 149 forks source link

Notifications don't show at all #533

Closed D4anielCB closed 3 years ago

D4anielCB commented 3 years ago

Expected Behavior

Notifications showing for scrobling and when synchronizingthe library

Current Behavior

When scrobbling or when synchronizing the notifications that used to show on kodi 18.9 and below are not showing in kodi 19 the addon is working for both situations mentioned, only the notification that is missing

Steps to Reproduce (for bugs)

  1. Enable notifications in the settings and sync collection on library update/cleaning
  2. Try to watch any tv show/movie
  3. Try to update the library

Context

Even this is not compromising its functionality I find the notifcations very useful, so i decided to report

Your Environment

Thanks for the great addon!

bromix commented 3 years ago

Same with me...noticed it today. I'm looking at the debug.log right now.

bromix commented 3 years ago

So, I updated my library and see in the log that the scan process is starting

2021-03-07 19:11:59.036 T:12396    INFO <general>: VideoInfoScanner: Starting scan ..

But after that, no trakt information at all. If I start trakt manually via the addon section...

2021-03-07 19:15:39.326 T:9680    DEBUG <general>: CPythonInvoker(4, C:\Users\<USERNAME>\AppData\Roaming\Kodi\addons\script.trakt\defaultscript.py): start processing
razzeee commented 3 years ago

Please see the readme on how to get log output by the script

bromix commented 3 years ago

I added my log so far.

2021-03-07 22:41:27.049 T:20836   DEBUG <general>: [script.trakt] resources.lib.service: [traktMonitor] onScanFinished(database: video)

kodi.log

sharkykh commented 3 years ago

Works for me (same environment as OP) after changing the following line: https://github.com/trakt/script.trakt/blob/v3.3.5/resources/lib/kodiUtilities.py#L22

-xbmc.executebuiltin("XBMC.Notification(%s,%s,%i,%s)" % (header, message, time, icon))
+xbmc.executebuiltin("Notification(%s,%s,%i,%s)" % (header, message, time, icon))

I have not followed any Kodi API changes over the years, though that is what I found here: https://kodi.wiki/view/GUI_tutorial#using_built-in_functions