search

trakt / script.trakt

Trakt.tv movie and TV show scrobbler for Kodi
GNU General Public License v2.0
318 stars 149 forks source link

got the media_type from selected item #542

Closed fatshotty closed 3 years ago

fatshotty commented 3 years ago

fix for skin widgets. Got the media_type from selected item instead of Container

razzeee commented 3 years ago

Can you give more context, what exactly this fixes?

fatshotty commented 3 years ago

Hi, you can reproduce the problem using a skin that is based on skin-shortcuts, such as ArcticHorizon, Bello, Aura... To reproduce:

Issue is related to the function kodiUtilities.getMediaInfo() because it is based on 'Container.Content(movies) , but in the Home page widget, there is no content. Container.Content(movies) returns 'None' . My fix make it based on ListItem.DBTYPE (the selected ListItem)

Kodi_Media_Center Kodi_Media_Center
razzeee commented 3 years ago

Thank you much clearer, will have a look this evening

fatshotty commented 3 years ago

yeah sure :)

fatshotty commented 3 years ago

it has been done on my main branch. should I redo the "pull - request" ?

razzeee commented 3 years ago

Only if it's a problem for you. I'm hoping to test and merge this in the coming days.

fatshotty commented 3 years ago

many thanks ;)

fatshotty commented 3 years ago

good. is the addon already upgradable on my kodi? :)

razzeee commented 3 years ago

No, I would normally batch some more changes into one release, and the last release was just 6 days ago. So I'll wait at least another week, before shipping a new build.