Fix title/year fallback ignoring year

[ZelKami]

This fixes #620

Example: You have Gossip Girl (2007) in your Trakt history and Gossip Girl (2021) in your library. You have "Fallback to title and year if necessary" activated and you want to sync your watched episodes to your Kodi library.

Current behavior

• findMediaObject is called with Gossip Girl (2007) as mediaObjectToMatch
• It is not matched with either the IMDB ID, TMDB ID or TVDB Id, so the result is still None
• Matching the show by title and year still gives no result, so the result is still none
• Matching the show only by title returns Gossip Girl (2021) from the Kodi library as a match, which is wrong

Behavior after the fix

• The mediaObjectToMatch has a title and year, so the if clause to look for a match by title and year is true
• There is no match in the Kodi library, so the result is still None
• The library listToSearch is not searched for a match only by title anymore, so the method correctly returns no match

I tested it on my Kodi instance for the ratings sync and the "Mark episodes from Trakt history as watched" sync and it should also work for movies as compareMovies uses the same findMediaObject method

[ZelKami]

I think the failed test_findMediaObject_match_by_title_should_match() is wrong. It suggests that the remote movie Blind (2014) should be matched to the local movie Blind (2014) but in my opinion the difference in years should suggest that those are different movies. I understood the fallback to matching only by title if the remote movie has no year (which is suggested a the comment in findMediaObject) or did I misunderstand something?

[razzeee]

Yeah, your fix does seem valid/ the old logic is very obviously broken from a control flow POV.

Which also suggests, that we need a test case more (besides fixing the one you mentioned) that checks that year and title match, but don't get overwritten by a third item, where just title matches.

[razzeee]

@ZelKami thanks for looking into this