trakt / script.trakt

Trakt.tv movie and TV show scrobbler for Kodi
GNU General Public License v2.0
320 stars 149 forks source link

How to disable scrobbling temporarily from within an addon #651

Open Gujal00 opened 4 months ago

Gujal00 commented 4 months ago

When trailers are watched through IMdB-Trailers addon, scrobbling marks the movie as watched

Expected Behavior

Advice needed if from within an addon scrobbling can be disabled for the time the addon is running

Current Behavior

For example if you play the trailer for "Civil War" from the IMdB-trailers addon, I can see that it is doing a post to https://api.trakt.tv/scrobble/start with the following data {"progress": 2.3650602409638557, "app_version": "4.4.0", "app_date": null, "movie": {"title": "Civil War", "year": 2024}}

when the trailer finishes i can see a post to https://api.trakt.tv/scrobble/stop with the following data {"progress": 99.17469879518072, "app_version": "4.4.0", "app_date": null, "movie": {"title": "Civil War", "year": 2024}} and the response has "action":"scrobble"

So when the trailer finishes, it shows up in my trakt history as if the movie has been watched

please help on how to overcome this issue in the IMdB-trailers addon

Possible Solution

a Joson-rpc call to indicate 'Do not scrobble' which could be utilised when the marking the listitem as resolved for playback

Context

Watching trailers in the addon causes all the movies marked as watched in trakt misleadingly.

Your Environment

razzeee commented 4 months ago

Try the exclude plugin setting and see if that keep it from happening (or is it a script?)

If that helps, you should be able to ignore it, by setting the plugin as exclude path by adding it's name to plugin://

https://github.com/trakt/script.trakt/blob/d45f1363c49c3e1e83dabacb70729cc3dec6a815/resources/lib/kodiUtilities.py#L98

Gujal00 commented 4 months ago

That will stop scrobbling for all addons such as Netflix and Prime. The intention is to disable for a specific addon from within the video addon itself programmatically such as Imdb-trailers which shouldnt be scrobbled

razzeee commented 4 months ago

That's what I said, if that works, you can just set the correct path to be ignored.