search

trallnag / prometheus-fastapi-instrumentator

Instrument your FastAPI with Prometheus metrics.
ISC License
948 stars 84 forks source link

Upgrade fastapi version to support >100.0 #281

Closed faizanazim11 closed 6 months ago

faizanazim11 commented 9 months ago

FastAPI version for the package has been locked to support only less than 100.0 which is resulting in failure of installation due to conflicting dependencies.

Many projects are adopting pydantic 2.x for validation. FastAPI version 10x.x version is required for pydantic 2.x.

Please upgrade the requirements for the package to support newer versions of FastAPI. I don't feel there is any change required to adapt to those versions.

machineCYC commented 7 months ago

I install this package 6.1.0 with fastapi 0.110.0 it works

faizanazim11 commented 7 months ago

I install this package 6.1.0 with fastapi 0.110.0 it works

It may be working when installed manually, but try installing using requirements.txt with the fastapi version as loosely coupled for automated resolution. It will get less than 0.100.0 as it is set in the pyproject.toml file of the package.

machineCYC commented 7 months ago

I also use the requirements.txt to install the packages, it works for me, you may need to provide reproduce steps

jmugan commented 6 months ago

I'm getting raise RuntimeError("Cannot add middleware after an application has started")

faizanazim11 commented 6 months ago

The new version 7.0.0 resolves the original query, closing this ticket.