tralph3 / Steam-Metadata-Editor

An easy to use GUI that edits the metadata of your Steam Apps
GNU General Public License v3.0
161 stars 18 forks source link

Can't save changes #10

Closed hazelnot closed 2 years ago

hazelnot commented 2 years ago

I can't seem to save any changes, no matter what I do the modified field stays as "false" and when I restart Steam nothing changes. The editor reports "Your changes have been successfully applied!"

hazelnot commented 2 years ago

I closed it and tried to open it up again, but now it won't launch at all.

Traceback (most recent call last):
  File "/usr/bin/steammetadataeditor", line 1562, in <module>
    mainWindow = MainWindow(silent=args.silent, export=args.export)
  File "/usr/bin/steammetadataeditor", line 104, in __init__
    self.create_main_window()
  File "/usr/bin/steammetadataeditor", line 125, in create_main_window
    self.appInfoVdf = VDF()
  File "/usr/bin/steammetadataeditor", line 1159, in __init__
    self.parsedAppInfo = self.read_all_apps()
  File "/usr/bin/steammetadataeditor", line 1252, in read_all_apps
    app['sections'] = self.parse_subsections()
  File "/usr/bin/steammetadataeditor", line 1199, in parse_subsections
    value = value_parsers[value_type]()
  File "/usr/bin/steammetadataeditor", line 1199, in parse_subsections
    value = value_parsers[value_type]()
  File "/usr/bin/steammetadataeditor", line 1199, in parse_subsections
    value = value_parsers[value_type]()
KeyError: 98

I had to reboot my PC to make it run again, which made the modified field change to true, but Steam still ignores it. After closing the program again, I have to reboot to get it running again.

I'm on Arch Linux, if that helps with anything.

tralph3 commented 2 years ago

Go to your steam installation folder (should be ~/.local/share/steam/). Look for the appcache folder, and delete the appinfo.vdf file inside. Try again and tell me what happens.

hazelnot commented 2 years ago

It now tells me "Steam couldn't be located in your system, please point to it's[sic] installation directory." I restarted Steam to try to regenerate the file, it kept saying Steam couldn't be located, and when I manually selected the path I got this:


Traceback (most recent call last):
  File "/usr/bin/steammetadataeditor", line 1553, in <module>
    STEAM_PATH = get_steam_path()
  File "/usr/bin/steammetadataeditor", line 1533, in get_steam_path
    config.add_section('STEAMPATH')
  File "/usr/lib/python3.9/configparser.py", line 1211, in add_section
    super().add_section(section)
  File "/usr/lib/python3.9/configparser.py", line 659, in add_section
    raise DuplicateSectionError(section)
configparser.DuplicateSectionError: Section 'STEAMPATH' already exists

It did start when I ran it again though, I just realized that after the fact. The changes I previously made are still showing up in the program but not in Steam, although at least now I can start it multiple times without having to reboot.

tralph3 commented 2 years ago

Well, to properly debug this I'd need you to send me your appinfo.vdf file along with your modifications, located in .local/share/Steam-Metadata-Editor/config/modifications.json

hazelnot commented 2 years ago

Here they are. I had to put the .vdf in a .zip and rename the .json to .txt so GitHub would let me upload them.

appinfo.vdf.zip modifications.json.txt

tralph3 commented 2 years ago

Ok I finally got around to taking a look at this, but nothing seems to be out of the ordinary. I took your modifications and your appinfo file and I can see your modifications on the program, the games are being marked as modified correctly, and Steam doesn't revert the changes (do note that I don't own any of the games you modified, but I did a modification for another game and it wasn't rejected). So, I don't really know what to say, nothing seems broken on my end.

Have you tried again in these days? Did you get it to work?

hazelnot commented 2 years ago

I tried it again, now it works. No idea why. Maybe a Steam update?

tralph3 commented 2 years ago

I doubt it, Steam updates shouldn't affect this in the slightest. Well, without anything to really go on I'll close the issue.

pas-de-2 commented 1 year ago

Same thing happened to me. Made my first modifications, restarted steam several times and they didn't take. Tried restarting SME, and it kept closing with this error:

Traceback (most recent call last):
  File "C:\Users\xx\Downloads\Steam-Metadata-Editor-master\src\steammetadataedi
tor.py", line 1557, in <module>
    mainWindow = MainWindow(silent=args.silent, export=args.export)
  File "C:\Users\xx\Downloads\Steam-Metadata-Editor-master\src\steammetadataedi
tor.py", line 106, in __init__
    self.appInfoVdf.parsedAppInfo[app]\
KeyError: 2115

Deleted config/modifications.json, which let me open SME again, made the same changes, and it worked :shrug:

tralph3 commented 1 year ago

If you get a key error, it usually means there's something screwed up in the appinfo file. Deleting it and letting Steam regenerate it usually fixes it.