tralph3 / Steam-Metadata-Editor

An easy to use GUI that edits the metadata of your Steam Apps
GNU General Public License v3.0
161 stars 18 forks source link

Error while launching: Failed to execute script steammetaeditor #11

Closed AadiSahni closed 2 years ago

AadiSahni commented 2 years ago

I launch steammetaeditor.exe and it shows the error: Failed to execute script steammetainstaller. I installed it through github and I am on Windows 10 20H2

tralph3 commented 2 years ago

Where did you get the exe from? I dropped the compiled executables, Python shouldn't really be distributed that way. You need to install Python with the Tk/Tcl package (it's a checkbox in the installer), then it should work. Let me know how it goes.

AadiSahni commented 2 years ago

I see. I found the exe on the assets page on this repo, i figured the need to compile the source code was an older requirement and you just forgot to update the description. I'll see how your solution works.

tralph3 commented 2 years ago

Has it worked? Can I close this issue?

AadiSahni commented 2 years ago

I'm afraid not. This might sound stupid but how do I run the py file. Got Python 3.10 installed.

tralph3 commented 2 years ago

Assuming you're on Windows, you just open it with python (right click, open with python). If not, you can run it via command line with python steammetadataeditor assuming you're on the folder where you have it stored.

AadiSahni commented 2 years ago

I run it, a cmd window pops up, and for a very small time, another window and then it exits.

tralph3 commented 2 years ago

Any output on the command line?

cloudhaacker commented 2 years ago

hey tralph3 I wanted to try this out too - I did the same thing initially and found this post - when I try to run this with the command line I get the following:

E:\Steam\Steam Metadata Editor>python steammetadataeditor.py Traceback (most recent call last): File "steammetadataeditor.py", line 1531, in mainWindow = MainWindow(silent=args.silent) File "steammetadataeditor.py", line 93, in init self.create_main_window() File "steammetadataeditor.py", line 307, in create_main_window self.mark_installed_games() File "steammetadataeditor.py", line 323, in mark_installed_games libraries = self.parse_library_folders(libraries.read()) File "steammetadataeditor.py", line 352, in parse_library_folders del lbryDict['TimeNextStatsReport'] KeyError: 'TimeNextStatsReport'

tralph3 commented 2 years ago

I openly admit this program is a mess of spaghetti code that I should be ashamed of. As such I began a rewrite a couple of days ago with the knowledge I acquired since I wrote it. However... it's going to take a while so, in the meantime, I pushed a quick patch that hopefully fixes this issue.

Since I can't reproduce it, I can't really test it, but in theory it should work now, try to download the latest commit.

cloudhaacker commented 2 years ago

Hey tralph3, that worked! Thanks for looking into it - and don't be ashamed, you're doing something most of us can't! I'll be messing around with this on windows while I wait for my SteamDeck! Thanks again! :)

tralph3 commented 2 years ago

Glad to hear! Do note that this was made primarily for Linux. As I don't use Windows, I didn't give it much priority, since you can use Steam Edit which works perfectly fine. I'll try to give it more attention in the rewrite.