tralph3 / ZeroTier-GUI

A Linux front-end for ZeroTier
GNU General Public License v3.0
211 stars 32 forks source link

Feature: added build for debian and red-hat based distros with docker #17

Closed yurireeis closed 2 years ago

yurireeis commented 2 years ago

What's new:

tralph3 commented 2 years ago

Thank you for the PR. If I understand correctly (never used Docker before), this is automating the process of creating an rpm package from the deb package, am I right? Wouldn't it be better to simply make another script to make the rpm package the same way I'm handling the deb one? Since you're already using the deb package in the Dockerfile, I think it would be easier to just make a script for rpm, it would clear the need for Docker and Make.

yurireeis commented 2 years ago

Thank you for the PR. If I understand correctly (never used Docker before), this is automating the process of creating an rpm package from the deb package, am I right? Wouldn't it be better to simply make another script to make the rpm package the same way I'm handling the deb one? Since you're already using the deb package in the Dockerfile, I think it would be easier to just make a script for rpm, it would clear the need for Docker and Make.

The main idea is to create both binaries with an immutable infrastructure using docker. In some cases, when some user tries to create a deb (or rpm) package using only the purposed script on project, the output must be different than expected, since They have different packages installed in their OS. With docker We reduce the chance of dealing with this kind of issue.

tralph3 commented 2 years ago

Well, I don't see any issue merging this, just answer that last question I have and I guess it's good to go.