tralves / groceries-ns-vue

🍏 🍍 🍓 A NativeScript+Vue iOS and Android app for managing grocery lists
303 stars 65 forks source link

Async Deps #3

Closed yankeeinlondon closed 6 years ago

yankeeinlondon commented 6 years ago

I was noticing in the Rollup build process the following warning comes up:

image

This can be traced back to this description in Rollup:

https://github.com/rollup/rollup/wiki/Troubleshooting#treating-module-as-external-dependency

which I presume means that while our own code is being aggregated and shaken the external deps are not. I think this is likely NOT desired but not entirely sure.

tralves commented 6 years ago

Yup. The warnings go away when the libs are added to the external(id) { part in the rollup config, but clearly there must be something wrong...

yankeeinlondon commented 6 years ago

I tried adding this:

external: [
  './node_modules/email-validator/index.js',
  './node_modules/nativescript-theme-core/css/*.css',
  './node_modules/nativescript-theme-core/scss/**/*.scss',
  './node_modules/nativescript-vue/dist/index.js',
  './node_modules/tns-core-modules/bundle-entry-points.js',
  './node_modules/vue-router/dist/vue-router.js',
  './node_modules/vuex/dist/vuex.js',
  './node_modules/vuex/dist/logger.js',
  './node_modules/vuex-router-sync/index.js',
],

but still get the same error. Have you got it working?

yankeeinlondon commented 6 years ago

Interesting. I bumped rollup-plugin-vue to 2.5.2 (from 2.4.2) and the error is gone now.

tralves commented 6 years ago

Sorry, I missed your reply. Anyway, I just updated the project to use ns-vue 2. Should be working now.