tramhao / termusic

Music Player TUI written in Rust
GNU General Public License v3.0
1.05k stars 44 forks source link

fix(playback::rusty): send EOS on SKIP with empty sink #307

Closed hasezoey closed 5 months ago

hasezoey commented 5 months ago

quick-fix to allow "skip to next" and "skip to previous" to still work when the sink is empty, as otherwise we wait for a EOS, which will never come. this case can happen if enqueuing a track has failed (like unsupported format).

in the future, this should be handled more gracefully than just in "skip" (like automatically trying to go to the next track on enqueue error). enqueue error (somewhat unrelated to this PR) also result in things described like when I click on an episode to play, termuisc player feezes, although it allows me to quit, and restart. (#306) as the error does not get passed to the TUI.