tramhao / termusic

Music Player TUI written in Rust
GNU General Public License v3.0
963 stars 42 forks source link

Add support for sixel #322

Closed CRAG666 closed 4 weeks ago

CRAG666 commented 1 month ago

https://en.wikipedia.org/wiki/Sixel I use foot terminal

hasezoey commented 1 month ago

sixel is already supported in master, you need to enable cover-viuer-sixel feature though

CRAG666 commented 4 weeks ago

@hasezoey thanks, how to set position the image in sixel?

hasezoey commented 4 weeks ago

it should work the same regardless of what backend is used, you can:

uwidev commented 2 weeks ago

I'm not too sure if this is a sixel issue or a foot issue, but I have this issue where album art is unresponsive or is rendered poorly. I can't even hide it.

I'm also using the foot terminal and building it from master (AUR termusic-git). Since I'm using foot, as expected I'm on a wayland environment (hyprland).

Something I didn't quite understand is that you said that it needs to be "enabled". How is this done? I couldn't find anything in the configuration files in ~/.config/termusic/. `Does it just look for fallbacks until it finds sixel? I removed the ueberzugpp package as a dependency to try to force it to use sixel, but it didn't change anything.

This picture is how the album art looks like after trying to move it down several times. image

Update: resizing the window "updates" the window and removes the artifacts. It also properly shows the album art as "gone" after removing it and resizing the window. I feel like this is an foot issue with how it works with updating it's window, not too sure though.

hasezoey commented 2 weeks ago

Does it just look for fallbacks until it finds sixel? I removed the ueberzugpp package as a dependency to try to force it to use sixel, but it didn't change anything.

AUR termusic-git compiles with --all-features meaning all cover targets are enabled by default, though the priority list is: kitty > iterm > sixel > uberzug source

Something I didn't quite understand is that you said that it needs to be "enabled". How is this done? I couldn't find anything in the configuration files in ~/.config/termusic/

Since my comment above config version v2 has been merged which has different header names and file names, for v2 look infile tui.toml under header coverart. As for enablement, it is enabled by default if compiled with any "cover" feature and your terminal supports it, it can only be disabled via the cli flag -c or --disable-cover currently.

Please note that the art display is quite a mess currently and is known to not clear correctly is some cases. (like #250, #115)

PS: config v2 is layout out so that cover art is not really meant to be re-positioned aside from alignment, but other parts still need adjustment to this


if you want to continue or more properly report your issue, please open a new issue as this issue is about adding sixel support not problems with it