tramitit / tramitit.github.io

Tramitit webpage
https://tramitit.com
MIT License
3 stars 0 forks source link

Add edit button linking to github and format some files #5

Closed awennersteen closed 4 months ago

awennersteen commented 4 months ago

Three possibilities, you have write access to repo (currently the two of us), you have a github account but no write access to the repo, and you don't have a github account/isn't logged in.

  1. Write access
    1. You'll be able to edit the file directly and save in the repo on github
  2. No write access
    1. Github explains to you how to fork the repo and let's you fork and edit
  3. No Github or not logged in to github
    1. you're met with the signup or login screen

It looks like this, IDK if it will look better perhaps to right-align the button? Maybe make it stand out more?

image

rbatista191 commented 4 months ago

@awennersteen looks great! I would probably add another block at the end (between the markdown and Disqus) with a Improve this article by editing it on GitHub:

Screenshot 2024-06-13 at 15 15 05

I will try to create the guide today, which can also be added to these individual pages.

awennersteen commented 4 months ago

Alright, in the end I decided that it made more sense to put the edit button on the right (just seems more conventional), and I added the call to action at the bottom. I also fixed some other i18n things that I realized that we hadn't handled. We currently only do this for en and fr so should generate for the rest too one by one.

image image

rbatista191 commented 4 months ago

Alright, in the end I decided that it made more sense to put the edit button on the right (just seems more conventional), and I added the call to action at the bottom.

Like it a lot more!

I also fixed some other i18n things that I realized that we hadn't handled. We currently only do this for en and fr so should generate for the rest too one by one.

Not sure I follow what you mean by We currently only do this for en and fr but we can discuss tomorrow.

notion-workspace[bot] commented 4 months ago

Add Edit button on every guide

notion-workspace[bot] commented 4 months ago

Add Edit button on every guide