search

trampgeek / moodle-qtype_coderunner

CodeRunner: A moodle quiz question type that runs student-submitted program code in a sandbox to check if it satisfies a given set of tests.
GNU General Public License v2.0
210 stars 121 forks source link

GDPR infringement #137

Open rschrenk opened 2 years ago

rschrenk commented 2 years ago

Hello,

we recognized, that qtype_coderunner uses Google APIs in https://github.com/trampgeek/moodle-qtype_coderunner/blob/dfd0ab58ef1236c81b491f48a8b08859e73fafce/bulktestindex.php#L129 just to load AJAX, which is available in Moodle anyway by using require(['core/ajax'], function($) {}).

As for European sites, this causes an infringement of the GDPR. Would it be possible to fix that?

Kind regards

mckeownp commented 10 months ago

Hi,

thanks for pointing this out.

This issue was fixed not long after it was posted but it wasn't closed off here. So I'm doing that now :)

See the https://github.com/trampgeek/moodle-qtype_coderunner/commit/e0f47b9f3b52b46e3e98a16850cda3466c7f75b8 commit for details.

There is a small typo (see if you can spot it) that means the expand/collapse buttons don't update from collapse to expand. This isn't a critical bug as the page is still usable, so we'll roll out the fix with other updates.

Cheers, Paul