Closed hugobritobh closed 3 years ago
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.
:x: Hugo de Brito Valadares Rodrigues Alves
:x: trampster
Thanks for your contribution, I can see a lot of work has gone into this, and there is a lot of value in here.
Unfortunately I can't accept this contribute as is:
Consider raising separate merge request for the following:
I don't want this to put you off, I can see that a lot of effort has gone into this, and there is stuff in this merge request that I would definitely accept.
it's all right
All unit tests passed, BUT some were not included because updated change.
Static method
Primitive types, vectors and lists passing through REF
Decimal treatment (be careful with internationalization. For example: PT_BR and US_EN)
Benchmarks using BenchmarkDotNet
There is a way to improve the list and vectors part. If I have time I will make this improvement.
when doing the merge with nullable types there were some problems and I returned the version.