trampster / JsonSrcGen

Json library that uses .NET 5 Source Generators
MIT License
148 stars 4 forks source link

Some changes #42

Closed hugobritobh closed 3 years ago

hugobritobh commented 3 years ago

All unit tests passed, BUT some were not included because updated change.

There is a way to improve the list and vectors part. If I have time I will make this improvement.

when doing the merge with nullable types there were some problems and I returned the version.

CLAassistant commented 3 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

:x: Hugo de Brito Valadares Rodrigues Alves
:x: trampster


Hugo de Brito Valadares Rodrigues Alves seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

trampster commented 3 years ago

Thanks for your contribution, I can see a lot of work has gone into this, and there is a lot of value in here.

Unfortunately I can't accept this contribute as is:

Consider raising separate merge request for the following:

I don't want this to put you off, I can see that a lot of effort has gone into this, and there is stuff in this merge request that I would definitely accept.

hugobritobh commented 3 years ago

it's all right