tranduybau / df-frontend-2023

https://df-frontend-2023-ashy.vercel.app
0 stars 1 forks source link

Submission for assignment 1 #3

Open tranduybau opened 1 year ago

tranduybau commented 1 year ago

Link:

https://df-frontend-2023-git-assignment-1-wiicamp-org.vercel.app/assignment-1/index.html

Note for team:

Great job, thank you for the project!

zlatanpham commented 1 year ago

Hello @tranduybau, great work!

Requirements

Final result: ✅ passed

Feedback

We also have some comments for your work:

  1. Avoid using inline JS in your HTML code. Better to use .addEventListender inside script.js file for separation of concern. https://github.com/tranduybau/df-frontend-2023/blob/main/assignment-1/index.html#L31
  2. Ensure that the close button, which uses an image inside, is accessible to screen readers. One way is by using aria-label="Close" on the button. https://github.com/tranduybau/df-frontend-2023/blob/main/assignment-1/index.html#L61-L63 image
  3. The class delete-btn-group both used in delete and add book, which is confusing. https://github.com/tranduybau/df-frontend-2023/blob/main/assignment-1/index.html#L75C58-L75C74 https://github.com/tranduybau/df-frontend-2023/blob/main/assignment-1/index.html#L125
  4. Try to add error handling for JSON parse by wrapping it inside a try-catch https://github.com/tranduybau/df-frontend-2023/blob/main/assignment-1/script.js#L23

🌟 Great job utilizing modern CSS features such as imports and variables to enhance the overall organization of your code.