search

tranduybau / df-frontend-2023

https://df-frontend-2023-ashy.vercel.app
0 stars 1 forks source link

Submission for assignment 3 #8

Open tranduybau opened 1 year ago

tranduybau commented 1 year ago

Link:

https://df-frontend-2023-kappa.vercel.app/

Note for team:

Great job, thank you for the project!

zlatanpham commented 12 months ago

Hello @tranduybau, I cannot deem your work as complete since there are several instances where TypeScript has not been implemented correctly, and some main functions and UI remain incomplete.

Requirements

Final result: ❌ failed as only done 60% of the requirements

Feedback

Here are some comments for your work:

  1. The search function is not operational, and there are several other functionalities that are incomplete, including pagination options and color customization. image image

  2. There is no interface for the Modal, Pagination: https://github.com/tranduybau/df-frontend-2023/blob/810cc2bb608d8a3f08eca35bed33d0e71d1316a7/assignment-3/src/components/Modal/index.tsx#L6 https://github.com/tranduybau/df-frontend-2023/blob/810cc2bb608d8a3f08eca35bed33d0e71d1316a7/assignment-3/src/components/Pagination/index.tsx#L6

  3. Apart from (2), few other places also won't have type declaration because the noImplicitAny is turn off. To prevent this issue, consider changing the configuration setting noImplicitAny to true. https://github.com/tranduybau/df-frontend-2023/blob/810cc2bb608d8a3f08eca35bed33d0e71d1316a7/assignment-3/tsconfig.json#L15