search

tranek / GASDocumentation

My understanding of Unreal Engine 5's GameplayAbilitySystem plugin with a simple multiplayer sample project.
MIT License
4.26k stars 789 forks source link

Possible unnecessary cast in PlayMontageAndWaitForEvent #109

Closed tommygod3 closed 1 year ago

tommygod3 commented 1 year ago

I can't seem to see any reason we have to cast the ASC to a UGDAbilitySystemComponent in this class? In which case this may be an unnecessary cast: https://github.com/tranek/GASDocumentation/blob/f986a00d224ebfb79472fa6ba37738d0bf926347/Source/GASDocumentation/Private/Characters/Abilities/AbilityTasks/GDAT_PlayMontageAndWaitForEvent.cpp#L22

tranek commented 1 year ago

Thanks! It was probably copied over from Epic's ARPG sample project.

tommygod3 commented 1 year ago

No worries, thank you for the fix! I would have put in a PR myself but have been looking into another issue: https://github.com/tranek/GASDocumentation/issues/111