Coderchat Assignment

[tranminhan]

Here is my week-2 assignment. Thank you!

/cc @coderschoolreview

[coderschoolreview]

Thank you for your Ruby submission, tranminhan!

:laughing: Everything looks good with the format of your submission. We'll be providing a detailed review soon!

[chug2k]

Good work, and sorry for the slow review! This homework is on authentication, using ActiveRecord::Relation, dealing with model associations, using partials, and the items under Bonus help with upcoming topics we will cover.

Hmm, it seems like you've taken your app down from Heroku, but that's okay - sorry for being so slow to grade.

Suggestions

• This isn't great to do in application_controller:

 include SessionsHelper
 include ApplicationHelper

This is making your code messy, because now all the helper methods will be available to your controller. Helpers are for views, so good examples of helper methods are truncate, number_to_currency, etc.

• You don't need to keep both read and read_at. If read_at is not nil (i.e. has a valid datetime) then you know that it has been read. ;)
• Interesting work with prospective_friends in user.rb! I like your approach. In the future, you might want to translate that into SQL, because that will get expensive quickly.

:clap: on the homework. Thanks!