search

trannamtrung1st / elFinder.Net.Core

An elFinder backend connector with less magic code and more compatibility. This enables .NET Standard 2.0 projects to easily integrate elFinder functionalities.
Apache License 2.0
12 stars 8 forks source link

MaxUploadConnections is not respected when you drill into a folder #31

Closed huwjeffries closed 2 years ago

huwjeffries commented 2 years ago

To see the issue, set MaxUploadConnections to some value other than 1 when creating the volumes.

On the initial api request to connector (cmd = open & init=1) we can see that the correct uploadMaxConn appears in the JSON.

Drill into a folder in elfinder and again look at the call to connector cmd=open call that occurred when you went into the folder. We see that uploadMaxConn is always set to 1.

I noticed this when experimenting with MaxUploadConnections =-1 to disable file upload chunking.

There's a line in FileSystemDriver.cs: initResp.options.uploadMaxConn = currentVolume.MaxUploadConnections; Which is involved when init =1, but not otherwise.

trannamtrung1st commented 2 years ago

Hi @huwjeffries , thanks for pointing it out. Please check out the latest version.

huwjeffries commented 2 years ago

Thanks for the quick response. The fix works perfectly.