search

tranquvis / SimpleSmsRemote

Android app for remotely controlling a phone through sms messages
MIT License
129 stars 37 forks source link

location as URL to map #15

Closed AlbertoDiazC closed 6 years ago

AlbertoDiazC commented 7 years ago

First of all, thank you for your efforts.

This is my request: SimpleSMSRemote sends location as latitude-longitude numbers, which isn't very user friendly. If possible, please add an option to enable sending location as a clickable URL. For example: https://www.google.com/maps?q=48.197611,15.780512

pl31 commented 6 years ago

Thanks from my side as well. Great App with nice UI. Clickable url would be really nice. Are there any GPS quality informations, which could be added to the message as well?

tranquvis commented 6 years ago

The API also provides an accuracy property. I will add that in the next version.

tranquvis commented 6 years ago

I implemented your feature requests in this commit: https://github.com/tranquvis/SimpleSmsRemote/commit/d35d29547324ab74d23e5d78e8b8c566f818e9fd 🏆 Thank you for your contributions.

pl31 commented 6 years ago

Awesome! Thanks.

pl31 commented 6 years ago

Hello Tranquis,

I tried the new version and it works great.

The quality informations are good as well, but there is still one edge case where those are not sufficent/misleading: the location api may give an old position. I got a position with "17m accuracy (68% probability)" but I was more than 100km away.

I took a look in the api and found a property getTime to get the date/time of the fix. Could you add the date when the location was updated to the sms as well?

Shall I create a new issue, or is it fine here?

Regards Patrick

tranquvis commented 6 years ago

Thank you for the information Patrick, Would be great, if you could create an issue.