search

tranquvis / SimpleSmsRemote

Android app for remotely controlling a phone through sms messages
MIT License
129 stars 37 forks source link

Add remote authentication module #44

Closed ubipo closed 3 years ago

ubipo commented 3 years ago

This adds a module for remote authentication, as described in #7.

I also upgraded the Maven version and targeted Java version because Android studio asked for it. Hope that doesn't break anything ;)

Since the ModuleUserData for the new authentication module does not need a granted phones list I moved that functionality to a new class, PhoneAllowlistModuleUserData. So all modules use PhoneAllowlistModuleUserData, except for the authentication module, which uses ModuleUserData.

The parameter description for the authentication module got a little hectic, so I enabled HTML for that textview and updated the parameter descriptions for the other modules.

I'm probably missing some stuff but overall I tried to keep the changes small.

ubipo commented 3 years ago

Thanks for the thorough review!

I went over all the suggestions and implemented the instrumentation tests. As with the module itself I did need to make some changes to the deeper logic.

I got 19 out of 60 failures but these all seem to be some functional problem (WifiManager.setWifiApEnabled not found, something with the display staying on when the test tried to turn it off etc.). The tests I implemented for GrantPhoneRemotely do all pass.