search

tranquvis / SimpleSmsRemote

Android app for remotely controlling a phone through sms messages
MIT License
129 stars 37 forks source link

Take a picture #8

Open Bobcadence opened 7 years ago

Bobcadence commented 7 years ago

Hello,

All my tried to use take picture command failed. The log «an unexpected error occurred». I am on a honor 5c with android 7.0 if it help. I will available to test your fix ;-)

tranquvis commented 7 years ago

Hello Bobcadence,

I have the same issue on my device. I inspected the code again, but I could not find any bug.

The problem in my case is: The camera must be opened before it can be used, which may take some time. This process does not succeed and times out.

Working with the diversity of cameras is really hard and fixing this bug may take a while. I will see what I can do.

I definitely keep you up to date.

tranquvis commented 7 years ago

I got it working. It was a multithreading problem. Obviously google changed the camera apis which caused problems with the Handler.

Please test this fix: Apk 1.1.1

Bobcadence commented 7 years ago

Hey!

I tried your fix. There are some progess. The command turn on the flash for 1second and save a «picture» with nothing.

Curiously the flash is always turn on even if it was disabled in the apps.

Le 4 juin 2017 19:24:05 GMT+02:00, Andreas Kaltenleitner notifications@github.com a écrit :

I got it working. It was a multithreading problem. Obviously google changed the camera apis which caused problems with the Handler.

Please test this fix: Apk 1.1.1

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/tranquvis/SimpleSmsRemote/issues/8#issuecomment-306054022

tranquvis commented 7 years ago

Disabling flash should work with my most recent commit.

The Problem with black pictures: This is a device specific issue, since its working for me. Maybe the rendering or compression algorithm is not supported on your device. I am sure that many people have similar problems, because I faced a lot of them when I developed this module. I'm not happy about this, but supporting take picture on all devices is a very time consuming process. I have not the time and not the devices in order to test and fix this issue. (Sorry)

Would be great if someone contributes to the development. ;)

Bobcadence commented 7 years ago

I disabled the flash and tried the fix you send me without success...However, it's not a must have feature for me. I prefer a good location and sound features. ( I have just an idea: it could be cool to use flash for morse signal like SOS) Futhermore i understand, you have few time for this project. :-)

If i was a dev, i would help. I could be a beta tester and translate the app, not more... OH wait, i me sure you appreciated a beer ;-)

Le 4 juin 2017 20:25:54 GMT+02:00, Andreas Kaltenleitner notifications@github.com a écrit :

Disabling flash should work with my most recent commit.

The Problem with black pictures: This is a device specific issue, since its working for me. Maybe the rendering or compression algorithm is not supported on your device. I am sure that many people have similar problems, because I faced a lot of them when I developed this module. I'm not happy about this, but supporting take picture on all devices is a very time consuming process. I have not the time and not the devices in order to test and fix this issue. (Sorry)

Would be great if someone contributes to the development. ;)

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/tranquvis/SimpleSmsRemote/issues/8#issuecomment-306057699

tranquvis commented 7 years ago

The flash fix has not been not built so far and is not included in the apk, which I sent.

Thank you very much for your engagement and your offer. But the most elaborate work is development and you need features to test. ;)