esbuild - Githubissues

transcend-io / penumbra

Encrypt/decrypt anything in the browser using streams on background threads.

https://penumbra-example.vercel.app/

Apache License 2.0

145 stars 19 forks source link

esbuild #229

Open bencmbrook opened 2 years ago

bencmbrook commented 2 years ago

Alt to #226 with esbuild only

worker is expected to be internally imported so will need to deprecate setWorkerLocation
switched mime-type to a lighter browser version (so we don't need to inline the whole mime-db)
example, demo, and tests working
karma still depends on webpack but could drop it entirely with a separate switch to esbuild
may want to add a cjs export as well

Related Issues

[none]

Public Changelog

[none]

Security Implications

[none]

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated
penumbra-example	✅ Ready (Inspect)	Visit Preview	Jul 16, 2022 at 1:51PM (UTC)

eligrey commented 2 years ago

These changes don't deprecate setWorkerLocation just yet. I think we can save that for 6.1

eligrey commented 2 years ago

@bencmbrook Where do I change the code that is calling yarn build:example in Vercel? I think that's the only remaining part to address before we can merge this

bencmbrook commented 2 years ago

@eligrey here it is https://vercel.com/transcend-io/penumbra-example/settings/general

eligrey commented 2 years ago

@bencmbrook thanks; I'll get this unblocked & ready for review by EOW

bencmbrook commented 2 years ago

@eligrey updated that vercel build script to yarn build:dist && cp -a dist/ example/dist/