transcend-io / terragrunt-atlantis-config

Generate Atlantis config for Terragrunt projects.
https://transcend.io/blog/why-we-use-terragrunt
MIT License
613 stars 96 forks source link

Docker images are not published #315

Open sylwit opened 7 months ago

sylwit commented 7 months ago

Hi all,

Is there a reason why docker images are no longer published to any registry ? https://github.com/transcend-io/terragrunt-atlantis-config/actions/runs/7702980093 action exists but fails

Thank you

Almenon commented 7 months ago

The action was broken when the most recent tag was created. Theoretically it should be fixed now. I just kicked off another run: https://github.com/transcend-io/terragrunt-atlantis-config/actions/runs/7984012107/job/21800132831

..... which failed. Looks like that will need to be fixed :|

sylwit commented 7 months ago

I think you're using a PAT that might have expired. You can probably used the config for ghcr described here https://github.com/docker/login-action?tab=readme-ov-file#github-container-registry

Almenon commented 7 months ago

That's a good guess, but we no longer use a PAT. You can see our current config here: https://github.com/transcend-io/terragrunt-atlantis-config/blob/master/.github/workflows/container-build.yml

sylwit commented 7 months ago

Can you try to add contents:read permissions https://docs.github.com/en/packages/managing-github-packages-using-github-actions-workflows/publishing-and-installing-a-package-with-github-actions#authenticating-to-package-registries-with-repository-scoped-permissions

Almenon commented 7 months ago

I'm not a maintainer. I forked the repo and verified that the action works correctly in my fork, so it looks like maybe some repo/package/org settings are incorrect in this repo. @dmattia can you look around, please?

Relevant: https://github.com/docker/build-push-action/issues/463#issuecomment-924995909 I would take a look at the package settings and see if those look correct

for example: https://i.imgur.com/wSQdxJt.png

dmattia commented 7 months ago

I've been diving into this, but am a bit confused still unfortunately.

I can verify on the package page that newer versions have not been published: https://github.com/transcend-io/terragrunt-atlantis-config/pkgs/container/terragrunt-atlantis-config%2Fslim

and I see that the run by @Almenon failed two weeks ago: https://github.com/transcend-io/terragrunt-atlantis-config/actions/runs/7984012107/attempts/1

but when I retried the job, it seems to have gotten a bit further, but still failed to push with a perms error after 10 mins: https://github.com/transcend-io/terragrunt-atlantis-config/actions/runs/7984012107/job/22403210971

When I view the package settings, it seems like you (and I as part of the Engineers group) should have access:

Screenshot 2024-03-07 at 11 25 01 AM

-config/actions/runs/7984012107/job/22403210971

I'm not sure what other settings I may be missing:

Screenshot 2024-03-07 at 11 44 45 AM
sylwit commented 6 months ago

@dmattia can you try to add the permissions contents: read in the workflow please

dmattia commented 6 months ago

Added the perm in https://github.com/transcend-io/terragrunt-atlantis-config/commit/a97a56d6bafdb85960624b0ba1e751b92cebf8bd

Watching release here: https://github.com/transcend-io/terragrunt-atlantis-config/actions/runs/8484604107

dmattia commented 6 months ago

Still seems to be failing ☹️ : https://github.com/transcend-io/terragrunt-atlantis-config/actions/runs/8485356519/job/23249970170

dmattia commented 6 months ago

I might just switch to trying Docker Hub maybe... That may take a bit more time though

alex-candfield commented 3 months ago

Have you tried this: https://stackoverflow.com/questions/75897093/error-buildx-failed-with-error-failed-to-solve-failed-to-push-ghcr-io-unex