transfem-org / Sharkey

🌎 A Sharkish microblogging platform πŸš€
https://joinsharkey.org/
73 stars 19 forks source link

some small ui tweaks #119

Closed wont-work closed 10 months ago

wont-work commented 10 months ago
before ![Screenshot 2023-10-30 at 15-19-55 @kopper](https://github.com/transfem-org/Sharkey/assets/106974765/933ad4d4-a5ec-423b-97a6-1e9d7f9b775d)
after ![Screenshot 2023-10-30 at 15-18-42 @kopper](https://github.com/transfem-org/Sharkey/assets/106974765/a2692382-001c-419c-a157-7be164c21e4e)

there are three parts of this pr i'm not too sure on:

Mar0xy commented 10 months ago

hide status indicators when they're in an "unknown" state

This mainly was left in by misskey to keep consistency so it's not just like woop all of a sudden the status indicator is not here while on other profiles it is.

add more shadows

A big issue I see with this is performance on the client as the more CSS Effects need to be rendered (especially on the profile page as it also has css effects for the background images which currently affect the entire site on stable and has already been fixed) the slower/laggier it gets.

Mar0xy commented 10 months ago

show a pointer cursor when hovering over clickable parts of notes when "Click to open notes" is enabled

While this is a nice idea on paper it kinda translates weirdly due to the fact that it makes it harder to indicate if someone is hovering over the footer icons, cw button and as well as making the cursor be basically a permanent pointer (which lets be honest when it comes to the way the pointer looks it has always looked weird/ugly).

wont-work commented 10 months ago

This mainly was left in by misskey to keep consistency so it's not just like woop all of a sudden the status indicator is not here while on other profiles it is.

:+1:, dropping that commit in this case

A big issue I see with this is performance on the client as the more CSS Effects need to be rendered (especially on the profile page as it also has css effects for the background images which currently affect the entire site on stable and has already been fixed) the slower/laggier it gets.

true, but imo there needs to be some way to separate things from the background, barely perceptible color changes do not cut it (especially on pages without a background image)

there may be a way to pull it off with borders which should be slightly more resource efficient, i'll have to experiment

While this is a nice idea on paper it kinda translates weirdly due to the fact that it makes it harder to indicate if someone is hovering over the footer icons, cw button

right now there is no other indication on what part of a note is clickable and what part isn't. especially on posts with reactions or audio where the empty space next to them do not open the post (or the empty space under the avatar, which in fairness seems to be consistent with masto)

the footer icons can be solved by giving them a hover color (which i'll may throw in with the next revision of this pr, depends on if my brain's willing to cooperate) (edit: there already seems to be css for doing this. are the colors just the same in the default themes?)

and the cw button changes background colors which feels reasonable to me (and the cursor doesn't change because the post hitbox is that close to the cw button)

not entirely sure on what you mean by "and as well as making the cursor be basically a permanent pointer (which lets be honest when it comes to the way the pointer looks it has always looked weird/ugly)." though

wont-work commented 10 months ago

revision 2: using a border does seem to look pretty nice, and should be less resource intensive compared to shadows. also snuck in a fix for shadows and transparent avatars in the profile page

Screenshot 2023-10-31 at 15-29-16 @kopper Screenshot 2023-10-31 at 15-28-29 @kopper

wont-work commented 10 months ago

there are a few more changes i'd like to make but they're significantly larger and probably deserve their own individual PRs (if i manage to pull them off, that is). un-drafting this pr

wont-work commented 10 months ago

dropped borders & rebased on develop