search

transfem-org / Sharkey

🌎 A Sharkish microblogging platform 🚀
https://joinsharkey.org/
74 stars 19 forks source link

Quick-and-dirty corner roundness toggle #124

Closed wont-work closed 10 months ago

wont-work commented 10 months ago

To keep things manageable I merged a lot of one off values into just a handful of common sizes, so some parts of the UI will look different than upstream even with the "Misskey" rounding mode.

A lot of find and replace were involved, so I definitely need another set of eyes to look over this and say what parts should be (un)rounded, marking as draft for now.

wont-work commented 10 months ago

i haven't found any obvious breakages (beyond the avatar thing fixed in d4d2f6f) after running this for the last day or so, and the issues i had with locales not updating fixed itself after i rebased the pr on latest develop, un-drafting this pr

Mar0xy commented 10 months ago

(beyond the avatar thing fixed in https://github.com/transfem-org/Sharkey/commit/d4d2f6f8710d8cfd43890cda09b0217a555d6ace)

Does this mean it also works fine with non-square avatars

wont-work commented 10 months ago

yep. that radius controls the avatar roundness, which gets set to 20% (edit: my local editor was on the develop branch, updated to correct value) with the .square class around line 189 (which gets applied by the square avatars setting)

Mar0xy commented 10 months ago

I see that some 5px radiuses get set to 4px with the radius xs variable is this intended

Insert5StarName commented 10 months ago

as far as i understand this is intended

wont-work commented 10 months ago

I see that some 5px radiuses get set to 4px with the radius xs variable is this intended

yep.

To keep things manageable I merged a lot of one off values into just a handful of common sizes, so some parts of the UI will look different than upstream even with the "Misskey" rounding mode.

wont-work commented 10 months ago

Then there is also the question about boot.js and error.css where the buttons get an very high radius set wouldn't this cause issues for when the error pages show up with the buttons

those are likely the upstream values carried over from the commit reverts. i'll prolly hardcode sharkey's radius values there in a bit.

i think the stying on those pages are separate enough from the "main" misskey app that it shouldn't cause any issues either way and is just down to preference

wont-work commented 10 months ago

nvm i took too long to write that reply

Mar0xy commented 10 months ago

nvm i took too long to write that reply

rip