transfem-org / Sharkey

🌎 A Sharkish microblogging platform 🚀
https://joinsharkey.org/
75 stars 19 forks source link

make träwelling masto integration (/oauth/decision) work #148

Closed tastytea closed 8 months ago

tastytea commented 8 months ago

Summary

it would be nice if https://traewelling.de/ would work with the Mastodon API emulation. 💖 currently i get this error after clicking accept on the oauth authorization dialog:

{
  "message": "Route POST:/oauth/decision not found",
  "error": "Not Found",
  "statusCode": 404
}

it does work with firefish, don't know if that's helpful 😊

Mar0xy commented 8 months ago

I will add this endpoint later

Mar0xy commented 8 months ago

it does work with firefish

I just checked and it seem firefish does not implement this endpoint either.

tastytea commented 8 months ago

I just checked and it seem firefish does not implement this endpoint either.

someone on firefish said it worked :thinking:

Mar0xy commented 8 months ago

someone on firefish said it worked 🤔

It turns out misskey had a special oauth/authorize page on the frontend which was the page that redirected to oauth/decision meanwhile on firefish it is just an endpoint that directly does all stuff

Mar0xy commented 8 months ago

Fixed the issue was caused by träwelling adding an / at the end of /oauth/authorize and fastify being fastify thinking it was a different endpoint immediately

image

tastytea commented 8 months ago

thank you! 💖

tastytea commented 7 months ago

it worked on 2023-11-09, but when i had to redo the linking of the account on 2023-11-19 it didn't work anymore. all i get is “An error has occured” right after logging in. i did not change anything in my installation, it's sharkey 2023.11.0 + 2fae63f + 885800e + d94b1c3

screenshot ![Screenshot_20231122-105413_Firefox](https://github.com/transfem-org/Sharkey/assets/3681516/c9e7ba02-312d-4cf3-8388-9b44ac4d7d40)
Mar0xy commented 7 months ago

I have realized this a while back but this is not at all related to the integration it is related to it just generally being broken once the apps get removed with it just never recreating them causing it to always error out the only solution I found so far was to make the app each time /oauth/authorize was called but this would come at the downside of it always making a new app.

tastytea commented 7 months ago

i see. is there a way to manually fix that?
i looked around in the database and found that there is an entry for träwelling in the “app” table but deleting that didn't do anything useful… :thinking: