search

transfem-org / Sharkey

🌎 A Sharkish microblogging platform 🚀
https://joinsharkey.org/
74 stars 19 forks source link

feat: Allow more than one avatar decoration #170

Closed codingneko closed 9 months ago

codingneko commented 9 months ago

Summary

I would like to have more than one avatar decoration

Purpose

Not much, strictly aesthetic. I just see no reason why we're limited to just one.

Mar0xy commented 9 months ago

I just see no reason why we're limited to just one.

I think this decision was made to not impact performance considering that if you were to allow multiple decorations you would need to:

  1. Get the entire object of all decorations in use
  2. Loop through all of the entries and add them on top of the avatar which can be taxing depending on what device is being used.

iirc: This means I am basically against doing this just for extra aesthetic with possible performance impact.

Insert5StarName commented 9 months ago

I just see no reason why we're limited to just one.

I think this decision was made to not impact performance considering that if you were to allow multiple decorations you would need to:

1. Get the entire object of all decorations in use

2. Loop through all of the entries and add them on top of the avatar which can be taxing depending on what device is being used.

iirc: This means I am basically against doing this just for extra aesthetic with possible performance impact.

i also think this would be a pretty bad idea tbh

codingneko commented 9 months ago

Sadge Maybe limit it to 3 decorations? It seems like a reasonable number but it also allows for some fairly solid customisation. If not that's ok, feel free to close the issue :)