transfem-org / Sharkey

🌎 A Sharkish microblogging platform 🚀
https://joinsharkey.org/
74 stars 19 forks source link

increase content warning length limit #193

Closed tastytea closed 7 months ago

tastytea commented 7 months ago

Summary

please increase the CW length limit (currently 100) to something more suitable for all languages. 200 should be enough i think, or maybe increase it to 500 to cover very rare cases?

Purpose

the current limit seems to have been added with japanese in mind, which uses less characters for the same sentence. in english 100 characters are sometimes not enough.

when writing or replying to a note with a CW over 100 characters, Sharkey answers with a popup saying “Invalid param.” i hit this problem approximately 6 times a year.

in mastodon the CW is only limited by the overall post characters limit but i rarely see extremely long CWs, so i don't think increasing the limit will lead to much unwanted shenanigans.

upstream issue, with more details: https://github.com/misskey-dev/misskey/issues/8777

dakkar commented 7 months ago

implementation note: the column in the database is varchar(512), so there's no real reason to enforce anything shorter fun: https://github.com/transfem-org/Sharkey/blob/develop/packages/backend/src/server/api/endpoints/notes/create.ts#L124 says 100 https://github.com/transfem-org/Sharkey/blob/develop/packages/backend/src/server/api/endpoints/notes/edit.ts#L142 says 250

(also, there's a test https://github.com/transfem-org/Sharkey/blob/develop/packages/backend/src/server/api/endpoints/notes/create.test.ts#L75-L78 that will need updating)